ranking.php

Where we find trouble with the latest release... and shoot it.

Post Reply
thekabal
Posts: 92
Joined: Sat Apr 19, 2014 10:32 pm

Re: ranking.php

Post by thekabal » Sun Jun 15, 2014 11:06 pm

Great catch.

It is fixed in the latest SVN. Unfortunately, it looks like fixing it for the last release would be a little challenging to do on the fly (without interactive testing).

Gives you something to look forward to in the next release! :)

User avatar
TheMightyDude
Site Admin
Posts: 248
Joined: Thu Apr 17, 2014 9:15 am

Re: ranking.php

Post by TheMightyDude » Sun Jun 15, 2014 11:53 pm

I think it is down to the changes when we added language switching and it not falling back to a default one to be added in the link, resulting in a & instead of a ? for the first GET argument.
There was a lot of changes back then so loads of stuff got broken when they was changed.
I even broke it on the live game so that the link would work which resulted in removing the language argument in the link.

I don't think the language argument in the link should be needed if we are to keep using Sessions, just set the session and use that and if not set fall back to server default.
This session would be set via the players options page and via the language flag part on the index page.
TheMightyDude::Blacknova Development.
Development Blog Twitter Twitch

Post Reply